Tidying up UI tests [7/N] #149473
Tidying up UI tests [7/N] #149473
Conversation
|
This PR modifies |
rustbot
added
S-waiting-on-review
| struct Bar<'a> { | ||
| data: &'a [u8], | ||
| } | ||
|
|
||
| impl<'a> Bar<'a> { | ||
| fn bar(self: &mut Bar) { | ||
| //~^ ERROR mismatched `self` parameter type | ||
| //~| NOTE expected struct `Bar<'a>` | ||
| //~| NOTE found struct `Bar<'_>` | ||
| //~| NOTE lifetime mismatch | ||
| //~| ERROR mismatched `self` parameter type | ||
| //~| NOTE expected struct `Bar<'a>` | ||
| //~| NOTE found struct `Bar<'_>` | ||
| //~| NOTE lifetime mismatch | ||
| } |
There was a problem hiding this comment.
I merged tests/ui/issues/issue-17740.rs with tests/ui/lifetimes/explicit-self-lifetime-mismatch.rs to organize them. Is that okay? If you think it's unnecessary, I'll revert it.
There was a problem hiding this comment.
No, no need to revert, moving tests out of tests/ui/issues is always welcome, this directory is a total mess and must be removed as a long term plan (there is 500+ tests remains or something, haven't visited this one for a while)
This comment has been minimized.
This comment has been minimized.
|
Quick update: From around Dec 2nd, I'll be offline for about a week due to a hospital stay (all fine!). After I return, responses may be delayed as I'm juggling my medical studies and a job search So, if you're fine with waiting until I return, feel free to assign PRs to me. I'll review them after I'm back |
tests/ui/invalid-module-declaration/invalid-module-declaration.rs duplicated of tests/ui/modules/missing_non_modrs_mod_inline.rs
|
@Kivooeo I wish you a smooth recovery and the best of luck with your job search! I don't want to place any extra burden on you, so I'll find a different, random reviewer for next PRs. Thank you very much for your reviews during this time:) |
|
Forget to say, but as you moved this interior mutability test to traits directory, feel free to squash |
fix explicit-call-to-dtor.rs fix explicit-call-to-supertrait-dtor.rs merge issues/issue-17740.rs with lifetimes/explicit-self-lifetime-mismatch.rs merge bare-fn-start.rs and trait-fn.rs into invalid-self-argument.rs add comment tests/ui/traits/catch-unwind-cell-interior-mut
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - #149393 (expand valid edition range for use-path-segment-kw.rs) - #149427 (Make the capitalization explicit on keyword misspell error) - #149433 (Use a delayed bug for this layout ICE) - #149473 (Tidying up UI tests [7/N]) - #149505 (Update the comment in the add_typo_suggestion function) - #149513 (`rust-analyzer` subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #149473 - reddevilmidzy:t7, r=Kivooeo Tidying up UI tests [7/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of #133895 removed directory `tests/ui/explicit`, `tests/ui/interior-mutability`, `tests/ui/invalid-module-declaration`, tests/ui/invalid-self-argument` r? Kivooeo
5 participants
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
removed directory
tests/ui/explicit,tests/ui/interior-mutability,tests/ui/invalid-module-declaration, tests/ui/invalid-self-argument`r? Kivooeo